Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/emr_cluster: Avoid spurious diff of log_uri #1374

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Aug 9, 2017

Fixes #1356

Test results

=== RUN   TestAccAWSEMRCluster_visibleToAllUsers
--- FAIL: TestAccAWSEMRCluster_visibleToAllUsers (435.08s)
	testing.go:435: Step 0 error: After applying this step, the plan was not empty:
		
		DIFF:
		
		UPDATE: aws_route_table.r
		  route.#:                                    "0" => "1"
		  route.3310190312.cidr_block:                "" => "0.0.0.0/0"
		  route.3310190312.egress_only_gateway_id:    "" => ""
		  route.3310190312.gateway_id:                "" => "igw-bf138ed8"
		  route.3310190312.instance_id:               "" => ""
		  route.3310190312.ipv6_cidr_block:           "" => ""
		  route.3310190312.nat_gateway_id:            "" => ""
		  route.3310190312.network_interface_id:      "" => ""
		  route.3310190312.vpc_peering_connection_id: "" => ""
		...
=== RUN   TestAccAWSEMRCluster_bootstrap_ordering
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (444.84s)
=== RUN   TestAccAWSEMRCluster_tags
--- PASS: TestAccAWSEMRCluster_tags (445.07s)
=== RUN   TestAccAWSEMRCluster_security_config
--- PASS: TestAccAWSEMRCluster_security_config (461.40s)
=== RUN   TestAccAWSEMRCluster_terminationProtected
--- PASS: TestAccAWSEMRCluster_terminationProtected (464.73s)
=== RUN   TestAccAWSEMRCluster_basic
--- PASS: TestAccAWSEMRCluster_basic (471.66s)
=== RUN   TestAccAWSEMRCluster_s3Logging
--- PASS: TestAccAWSEMRCluster_s3Logging (884.87s)

That one failure is intermittent and unrelated to this PR.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Aug 9, 2017
@radeksimko radeksimko force-pushed the b-emr-diff-mismatch branch 3 times, most recently from 9161095 to 0d9c4b6 Compare August 9, 2017 13:16
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 3d60684 into master Aug 9, 2017
@radeksimko radeksimko deleted the b-emr-diff-mismatch branch August 9, 2017 15:41
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
…-mismatch

r/emr_cluster: Avoid spurious diff of log_uri
@agalazis
Copy link

agalazis commented Oct 15, 2017

which version is this fix included in?(I guess 1.0?)

@radeksimko
Copy link
Member Author

radeksimko commented Oct 15, 2017

@agalazis correct, the easiest way to find out when was a given PR released is to use Ctrl/Cmd+F in the Changelog with the PR number.

https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md#100-september-27-2017

@diddle-doo
Copy link

I am still having an issue, in-spite of upgrading the provider version
terraform --version
Terraform v0.11.7

  • provider.aws v1.25.0

    log_uri:                                            "s3n://logs-xxxxxx-us-east-1/logs/" => "s3://logs-xxxxxx-us-east-1/logs" (forces new resource)
    

can you please help?

@bflad
Copy link
Contributor

bflad commented Jul 2, 2018

@diddle-doo you need to add a trailing / in your configuration.

"s3n://logs-xxxxxx-us-east-1/logs/" => "s3://logs-xxxxxx-us-east-1/logs" is saying:

  • The API is returning: s3n://logs-xxxxxx-us-east-1/logs/
  • Your configuration appears to have: s3://logs-xxxxxx-us-east-1/logs
  • The code change here allows Terraform to accept both s3n://logs-xxxxxx-us-east-1/logs/ and s3://logs-xxxxxx-us-east-1/logs/ (note trailing / is still required)

@diddle-doo
Copy link

Thank you :)

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_emr_cluster.log_uri forces new resource
5 participants