support for importing aws_default_route_table resource

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12912

Release note for CHANGELOG:

add support for importing aws_default_route_table resource and set tags on creation

Output from acceptance testing:

--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (20.22s)
--- PASS: TestAccAWSDefaultRouteTable_basic (40.65s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (50.58s)
--- PASS: TestAccAWSDefaultRouteTable_swap (70.84s)
--- PASS: TestAccAWSDefaultRouteTable_Route (86.11s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (296.34s)

[DrFaust92]

i think this is partially similar to #12858 (from tags perspective)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_ -timeout 120m
=== RUN   TestAccAWSDefaultRouteTable_basic
=== PAUSE TestAccAWSDefaultRouteTable_basic
=== RUN   TestAccAWSDefaultRouteTable_disappears_Vpc
=== PAUSE TestAccAWSDefaultRouteTable_disappears_Vpc
=== RUN   TestAccAWSDefaultRouteTable_Route
=== PAUSE TestAccAWSDefaultRouteTable_Route
=== RUN   TestAccAWSDefaultRouteTable_swap
=== PAUSE TestAccAWSDefaultRouteTable_swap
=== RUN   TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== PAUSE TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== RUN   TestAccAWSDefaultRouteTable_vpc_endpoint
=== PAUSE TestAccAWSDefaultRouteTable_vpc_endpoint
=== CONT  TestAccAWSDefaultRouteTable_disappears_Vpc
=== CONT  TestAccAWSDefaultRouteTable_vpc_endpoint
=== CONT  TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== CONT  TestAccAWSDefaultRouteTable_swap
=== CONT  TestAccAWSDefaultRouteTable_Route
=== CONT  TestAccAWSDefaultRouteTable_basic
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (25.15s)
--- PASS: TestAccAWSDefaultRouteTable_basic (52.36s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (56.68s)
--- PASS: TestAccAWSDefaultRouteTable_swap (80.88s)
--- PASS: TestAccAWSDefaultRouteTable_Route (99.38s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (315.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	315.272s

[anGie44]

@DrFaust92 thanks for catching that! I'll remove the change from here then and note expected test failures

[anGie44]

Updated acceptance test output:

--- FAIL: TestAccAWSDefaultRouteTable_Route (41.33s)
--- FAIL: TestAccAWSDefaultRouteTable_vpc_endpoint (41.80s)
--- FAIL: TestAccAWSDefaultRouteTable_swap (43.09s)
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (20.78s)
--- PASS: TestAccAWSDefaultRouteTable_basic (44.67s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (336.92s)

Note: failures to be fixed with #12858

[anGie44]

After merging with master, acceptance test output:

PASS:  TestAccAWSDefaultRouteTable_disappears_Vpc
PASS:  TestAccAWSDefaultRouteTable_basic
PASS:  TestAccAWSDefaultRouteTable_tags
PASS:  TestAccAWSDefaultRouteTable_vpc_endpoint
PASS:  TestAccAWSDefaultRouteTable_swap
PASS:  TestAccAWSDefaultRouteTable_Route
PASS:  TestAccAWSDefaultRouteTable_Route_TransitGatewayID

[bflad]

Looks good! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (8.23s)
--- PASS: TestAccAWSDefaultRouteTable_basic (16.07s)
--- PASS: TestAccAWSDefaultRouteTable_tags (22.78s)
--- PASS: TestAccAWSDefaultRouteTable_swap (29.41s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (30.03s)
--- PASS: TestAccAWSDefaultRouteTable_Route (34.26s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (328.04s)

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!