Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_api_gateway_rest_api: Prevent error with VPC Endpoint configured APIs #12825

Merged
merged 1 commit into from
Apr 29, 2020
Merged

data-source/aws_api_gateway_rest_api: Prevent error with VPC Endpoint configured APIs #12825

merged 1 commit into from
Apr 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #12350
Reference: #8223

Release note for CHANGELOG:

* data-source/aws_api_gateway_rest_api: Prevent error with VPC Endpoint configured APIs

Previously:

    TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds: testing.go:669: Step 0 error: errors during apply:

        Error: error setting endpoint_configuration: endpoint_configuration.0.vpc_endpoint_ids: '': source data must be an array or slice, got struct

          on /var/folders/w8/05f3x02n27x72g0mc2jy6_180000gp/T/tf-test660234204/main.tf line 62:
          (source code not available)

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsApiGatewayRestApi_basic (18.71s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds (151.75s)

--- PASS: TestAccAWSAPIGatewayRestApi_tags (66.14s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (89.86s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (118.54s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (187.17s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (239.32s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (370.75s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (459.60s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (505.99s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (690.91s)

@bflad
data-source/aws_api_gateway_rest_api: Prevent error with VPC Endpoint…
0ddd61b 
… configured APIs

Reference: #12350
Reference: #8223

Previously:

```
    TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds: testing.go:669: Step 0 error: errors during apply:

        Error: error setting endpoint_configuration: endpoint_configuration.0.vpc_endpoint_ids: '': source data must be an array or slice, got struct

          on /var/folders/w8/05f3x02n27x72g0mc2jy6_180000gp/T/tf-test660234204/main.tf line 62:
          (source code not available)
```

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_basic (18.71s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds (151.75s)

--- PASS: TestAccAWSAPIGatewayRestApi_tags (66.14s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (89.86s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (118.54s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (187.17s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (239.32s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (370.75s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (459.60s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (505.99s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (690.91s)
```
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Apr 15, 2020
@bflad bflad requested a review from a team April 15, 2020 02:55
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 15, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2020
@bflad bflad linked an issue Apr 17, 2020 that may be closed by this pull request
Error when retrieving a Gateway API ( Endpoint_type: private with VPC Endpoint) in data #12870
Closed
@bflad bflad mentioned this pull request Apr 17, 2020
Closed
gdavison
gdavison approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayRestApi_policy (62.75s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds (107.48s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (118.34s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (126.17s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_basic (157.04s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (230.53s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (370.42s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (379.43s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (430.91s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (480.52s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (641.08s)

@bflad bflad merged commit 6ba5f2e into master Apr 29, 2020
@bflad bflad deleted the b-aws_api_gateway_rest_api-vpc_endpoint_ids-TypeSet branch April 29, 2020 23:09
bflad added a commit that referenced this pull request Apr 29, 2020
@bflad
Update CHANGELOG for #12825
75efb2b
@bflad bflad added this to the v2.60.0 milestone Apr 30, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@bflad @adamdecaf
data-source/aws_api_gateway_rest_api: Prevent error with VPC Endpoint…
a7ddfe9 
… configured APIs (hashicorp#12825)

Reference: hashicorp#12350
Reference: hashicorp#8223

Previously:

```
    TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds: testing.go:669: Step 0 error: errors during apply:

        Error: error setting endpoint_configuration: endpoint_configuration.0.vpc_endpoint_ids: '': source data must be an array or slice, got struct

          on /var/folders/w8/05f3x02n27x72g0mc2jy6_180000gp/T/tf-test660234204/main.tf line 62:
          (source code not available)
```

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_basic (18.71s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds (151.75s)

--- PASS: TestAccAWSAPIGatewayRestApi_tags (66.14s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (89.86s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (118.54s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (187.17s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (239.32s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (370.75s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (459.60s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (505.99s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (690.91s)
```
@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.60.0
Development

Successfully merging this pull request may close these issues.

Error when retrieving a Gateway API ( Endpoint_type: private with VPC Endpoint) in data
2 participants
@bflad @gdavison