-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add path to smb fileshare schema #12623
enhancement: add path to smb fileshare schema #12623
Conversation
a3ef303
to
3251991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, @artur-sak13 🚀
Output from acceptance testing:
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (241.49s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (250.01s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (301.25s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (310.96s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (312.38s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (313.12s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (318.51s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (388.64s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (390.32s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (678.03s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (824.09s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (868.55s)
This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
…corp#12623) Output from acceptance testing: ``` --- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (241.49s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (250.01s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (301.25s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (310.96s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (312.38s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (313.12s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (318.51s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (388.64s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (390.32s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (678.03s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (824.09s) --- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (868.55s) ```
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
The path value is retrieved after the resource is created/updated but since it was missing from the schema it's not available for output as per the documentation.
Community Note
Closes #12622
Related To #12527
Release note for CHANGELOG:
Output from acceptance testing: