Add outpost_arn to instance datasource

[johnbarney]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12302

Release note for CHANGELOG:

Adds Outpost support to instance datasource
Adds Outpost support to instance resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstanceDataSource_basic -timeout 120m
=== RUN   TestAccAWSInstanceDataSource_basic
=== PAUSE TestAccAWSInstanceDataSource_basic
=== CONT  TestAccAWSInstanceDataSource_basic
--- PASS: TestAccAWSInstanceDataSource_basic (194.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	195.632s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_basic -timeout 120m
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_basic (311.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	313.473s

[johnbarney]

Requires #12097 to run test in addition to an Outpost to test with

I wasn't sure if datasources should be tested in this way, or if the test should only cover filters. Happy to remove if needed.

[ewbankkit]

@johnbarney Thanks for this.
You could add a check to some (at least TestAccAWSInstanceDataSource_basic) of the other acceptance tests to check that the outpost_arn attribute is empty.

[johnbarney]

Done

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstanceDataSource_basic -timeout 120m
=== RUN   TestAccAWSInstanceDataSource_basic
=== PAUSE TestAccAWSInstanceDataSource_basic
=== CONT  TestAccAWSInstanceDataSource_basic
--- PASS: TestAccAWSInstanceDataSource_basic (161.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       162.630s

[johnbarney]

Requires changes from #12097

$ AWS_OUTPOST_ARN=arn:aws:outposts:us-west-2:<snip>:outpost/op-<snip> make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_outpost'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_outpost -timeout 120m
=== RUN   TestAccAWSInstance_outpost
=== PAUSE TestAccAWSInstance_outpost
=== CONT  TestAccAWSInstance_outpost
--- PASS: TestAccAWSInstance_outpost (273.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	275.827s

[bflad]

Verified, thanks so much, @johnbarney! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSInstance_basic (176.36s)
--- PASS: TestAccAWSInstance_outpost (105.96s)

--- PASS: TestAccAWSInstanceDataSource_basic (136.32s)

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!