Added image scanning configuration to aws_ecr_repository resource

[sergei-ivanov]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10656

Release note for CHANGELOG:

Adds `image_scanning_configuration` to `aws_ecr_repository` resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcrRepository_image_scanning_configuration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSEcrRepository_image_scanning_configuration -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSEcrRepository_image_scanning_configuration
=== PAUSE TestAccAWSEcrRepository_image_scanning_configuration
=== CONT  TestAccAWSEcrRepository_image_scanning_configuration
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (40.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.956s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.029s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.004s [no tests to run]

[bflad]

Hi @sergei-ivanov 👋 Thank you very much for submitting this. A few minor things and this should be good to go. Please reach out if you have any questions or do not have time to implement the feedback.

[sergei-ivanov]

@bflad I have implemented the requested changes, and improved the test further (in my test environment I also tested it for compatibility with resources created by an earlier version of aws provider).

Here's the result of a test run with the latest code:

$ make testacc TESTARGS='-run=TestAccAWSEcrRepository_image_scanning_configuration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSEcrRepository_image_scanning_configuration -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSEcrRepository_image_scanning_configuration
=== PAUSE TestAccAWSEcrRepository_image_scanning_configuration
=== CONT  TestAccAWSEcrRepository_image_scanning_configuration
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (95.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	95.072s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.003s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.005s [no tests to run]

[bflad]

This looks great, thanks for the quick implementation and updates, @sergei-ivanov 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEcrRepositoryPolicy_basic (8.78s)
--- PASS: TestAccAWSEcrRepository_basic (9.01s)
--- PASS: TestAccAWSEcrRepository_immutability (9.54s)
--- PASS: TestAccAWSEcrRepository_tags (13.60s)
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (20.62s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (26.18s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEcrRepository_immutability (5.62s)
--- PASS: TestAccAWSEcrRepository_basic (5.92s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (5.97s)
--- PASS: TestAccAWSEcrRepository_tags (6.91s)
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (8.65s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (11.49s)

[bflad]

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!