d/aws_vpc_endpoint: Add support for tag filters

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10465.

Release note for CHANGELOG:

data-source/aws_vpc_endpoint: Add `filter` attribute and support for filtering by `tags`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpcEndpoint_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== RUN   TestAccDataSourceAwsVpcEndpoint_byId
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byId
=== RUN   TestAccDataSourceAwsVpcEndpoint_byFilter
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byFilter
=== RUN   TestAccDataSourceAwsVpcEndpoint_byTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_interface
=== PAUSE TestAccDataSourceAwsVpcEndpoint_interface
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== CONT  TestAccDataSourceAwsVpcEndpoint_interface
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== CONT  TestAccDataSourceAwsVpcEndpoint_byTags
=== CONT  TestAccDataSourceAwsVpcEndpoint_byFilter
=== CONT  TestAccDataSourceAwsVpcEndpoint_byId
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (46.98s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (47.24s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (47.37s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (47.94s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (52.93s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (188.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	188.724s

[bflad]

Looks good with one non-blocking nit for the future, thanks @ewbankkit 🚀

--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (23.79s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (23.86s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (23.94s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (23.95s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (24.23s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (139.87s)

[bflad]

Nit: Data source testing is easier with resource.TestCheckResourceAttrPair() so you don't need to know the exact details of the resource you're matching while still verifying it matches the expected values 👍 , e.g.

resource.TestCheckResourceAttrPair(datasourceName, "vpc_endpoint_type", resourceName, "vpc_endpoint_type"),

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!