Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QLDB Ledger resource and data lookup #10394

Merged
merged 6 commits into from
Nov 1, 2019
Merged

Implement QLDB Ledger resource and data lookup #10394

merged 6 commits into from
Nov 1, 2019

Conversation

kristiandrucker
Copy link
Contributor

@kristiandrucker kristiandrucker commented Oct 5, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10069

Release note for CHANGELOG:

* data-source/aws_qldb_ledger: Implement a QLDB Ledger data source (#10069)
* resource/aws_qldb_ledger: Implement a QLDB Ledger resource (#10069)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSQLDBLedger_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSQLDBLedger_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSQLDBLedger_basic
=== PAUSE TestAccAWSQLDBLedger_basic
=== CONT  TestAccAWSQLDBLedger_basic
--- PASS: TestAccAWSQLDBLedger_basic (25.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       25.839s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.007s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.013s [no tests to run]

make testacc TESTARGS='-run=TestAccAWSQLDBLedger_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSQLDBLedger_Tags -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSQLDBLedger_Tags
=== PAUSE TestAccAWSQLDBLedger_Tags
=== CONT  TestAccAWSQLDBLedger_Tags
--- PASS: TestAccAWSQLDBLedger_Tags (60.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       60.427s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.007s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.019s [no tests to run]

make testacc TESTARGS='-run=TestAccDataSourceAwsQLDBLedger'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccDataSourceAwsQLDBLedger -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccDataSourceAwsQLDBLedger
=== PAUSE TestAccDataSourceAwsQLDBLedger
=== CONT  TestAccDataSourceAwsQLDBLedger
--- PASS: TestAccDataSourceAwsQLDBLedger (28.82s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       28.866s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.011s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.014s [no tests to run]

...

@kristiandrucker kristiandrucker requested a review from a team October 5, 2019 15:11
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 5, 2019
@ewbankkit
Copy link
Contributor

@kristiandrucker Thanks for this. 👏
Could you please move the tagging implementation to the new codegen mechanism - See #10313 for documentation.

@kristiandrucker
Copy link
Contributor Author

@evanphx np.
Sure. I wasn't aware of that. Let me redo and I'll commit it soon.

@kristiandrucker
Copy link
Contributor Author

@evanphx PR updated

@pbalduino
Copy link

Thank you @kristiandrucker

bflad
bflad suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kristiandrucker 👋 Thank you for contributing this. Please see the below for an initial review and reach out if you have any questions about the feedback items or do not have time to implement them.

aws/data_source_aws_qldb_ledger.go Outdated Show resolved Hide resolved
aws/data_source_aws_qldb_ledger.go Outdated Show resolved Hide resolved
aws/data_source_aws_qldb_ledger_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_qldb_ledger_test.go Outdated Show resolved Hide resolved
aws/internal/keyvaluetags/service_generation_customizations.go Outdated Show resolved Hide resolved
aws/resource_aws_qldb_ledger_test.go Outdated Show resolved Hide resolved
website/docs/d/qldb_ledger.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/r/qldb_ledger.html.markdown Outdated Show resolved Hide resolved
website/docs/r/qldb_ledger.html.markdown Outdated Show resolved Hide resolved
@bflad bflad added new-data-source Introduces a new data source. new-resource Introduces a new resource. waiting-response Maintainers are waiting on response from community or contributor. labels Oct 10, 2019
@bflad bflad self-assigned this Oct 10, 2019
@kristiandrucker
Copy link
Contributor Author

@bflad can you re-review this?

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 21, 2019
bflad
bflad suggested changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kristiandrucker 👋 Thanks for those updates, this is shaping up nicely. A few more items and then this should be good to go. Please reach out if you have any questions.

aws/data_source_aws_qldb_ledger_test.go Show resolved Hide resolved
aws/internal/keyvaluetags/update_tags_gen.go Show resolved Hide resolved
aws/resource_aws_qldb_ledger.go Outdated Show resolved Hide resolved
aws/resource_aws_qldb_ledger.go Outdated Show resolved Hide resolved
aws/resource_aws_qldb_ledger.go Outdated Show resolved Hide resolved
website/docs/d/qldb_ledger.html.markdown Outdated Show resolved Hide resolved
website/docs/d/qldb_ledger.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/r/qldb_ledger.html.markdown Show resolved Hide resolved
website/docs/d/qldb_ledger.html.markdown Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 1, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 1, 2019
bflad
bflad approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @kristiandrucker, two very minor fixes on merge and pulling this in. 🚀

Output from acceptance testing after test fix:

--- PASS: TestAccAWSQLDBLedger_basic (42.55s)
--- PASS: TestAccAWSQLDBLedger_Tags (59.12s)
--- PASS: TestAccDataSourceAwsQLDBLedger (72.38s)

aws/internal/keyvaluetags/update_tags_gen.go Show resolved Hide resolved
aws/resource_aws_qldb_ledger_test.go
testAccCheckAWSQLDBLedgerExists(resourceName, &qldbCluster),
testAccMatchResourceAttrRegionalARN(resourceName, "arn", "qldb", regexp.MustCompile(`ledger/.+`)),
resource.TestMatchResourceAttr(resourceName, "name", regexp.MustCompile("test-ledger-[0-9]+")),
resource.TestCheckResourceAttr(resourceName, "permissions_mode", "ALLOW_ALL"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one check with removal of the attribute:

--- FAIL: TestAccAWSQLDBLedger_basic (40.98s)
    testing.go:615: Step 0 error: Check failed: Check 4/6 error: aws_qldb_ledger.test: Attribute 'permissions_mode' not found

Will remove this line on merge.

@bflad bflad merged commit 5eaabea into hashicorp:master Nov 1, 2019
bflad added a commit that referenced this pull request Nov 1, 2019
@bflad
service/qldb: Address PR #10394 feedback
de6f9c9 
Output from acceptance testing:

```
--- PASS: TestAccAWSQLDBLedger_basic (42.55s)
--- PASS: TestAccAWSQLDBLedger_Tags (59.12s)
--- PASS: TestAccDataSourceAwsQLDBLedger (72.38s)
```
bflad added a commit that referenced this pull request Nov 1, 2019
@bflad
Update CHANGELOG for #10394
3e66dbe
@kristiandrucker kristiandrucker deleted the f-aws-qldb-ledger branch November 4, 2019 09:45
@bflad bflad added the service/qldb Issues and PRs that pertain to the qldb service. label Nov 4, 2019
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
provider: Add missing pull request labeling for qldb
568d39e 
Reference: #10394
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
Various hashibot labeling fixes/additions (#10732)
f5b1da3 
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore

Reference: #10730

The CloudTrail Trail resource is named just `aws_cloudtrail`.

* provider: Hashibot pull request labeling for route53resolver should include underscore

Reference: #10348

* provider: Add missing pull request labeling for qldb

Reference: #10394

* provider: Fix hashibot pull request labeling for athena

Reference: #10609

* provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link

Reference: #10561
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 7, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/qldb Issues and PRs that pertain to the qldb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kristiandrucker @ewbankkit @pbalduino @bflad