Revert retry logic change that's apparently causing policy not found …

[ryndaniels]

…errors

The timing of the regression (v2.25.0) noted in #9918 points to the changes made in #9766 being at fault here. I've been unable to reproduce the error, but given the number of 👍 on it, it seems prudent to revert for now.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9918

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_iam_policy_attachment: Revert a change causing errors with policies not being found during attachment

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSRolePolicyAttachment_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRolePolicyAttachment_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRolePolicyAttachment_basic
=== PAUSE TestAccAWSRolePolicyAttachment_basic
=== RUN   TestAccAWSRolePolicyAttachment_disappears
=== PAUSE TestAccAWSRolePolicyAttachment_disappears
=== RUN   TestAccAWSRolePolicyAttachment_disappears_Role
=== PAUSE TestAccAWSRolePolicyAttachment_disappears_Role
=== CONT  TestAccAWSRolePolicyAttachment_basic
=== CONT  TestAccAWSRolePolicyAttachment_disappears_Role
=== CONT  TestAccAWSRolePolicyAttachment_disappears
--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (28.15s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (28.27s)
--- PASS: TestAccAWSRolePolicyAttachment_basic (52.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       53.797s

[aeschright]

Onward!

--- PASS: TestAccAWSRolePolicyAttachment_disappears_Role (16.25s)
--- PASS: TestAccAWSRolePolicyAttachment_disappears (16.63s)
--- PASS: TestAccAWSRolePolicyAttachment_basic (28.99s)

[ghost]

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!