Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added variable validation to var.rotation_interval_month #103

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Dec 22, 2022

Description

  • fix: added variable validation to var.rotation_interval_month to only allow value between 1 and 12.
  • documentation and variable description cleanup
  • updated the default example to use ibm_resource_instance to provision the KP instance instead of the terraform-ibm-key-protect module since it also requires restapi provider (Had to skip upgrade test for this - no impact to main module)
  • test cleanup (removed code duplication)

Check the relevant boxes:

  • Bug fix (nonbreaking change that fixes an issue)
  • New feature (nonbreaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI related update (pipeline, etc.)

Checklist

  • If relevant, a test for the change has been added or updated as part of this PR.
  • If relevant, documentation for the change has been added or updated as part of this PR.

Merge

  • Merge using "Squash and merge".
  • Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

BREAKING CHANGE: consumers who do not have private endpoints enabled in their instance to have to explicitly now set endpoint_type to public
@ocofaigh ocofaigh changed the title fix: added variable validation to var.rotation_interval_month to only allow value between 1 and 12 fix: updated the default value of endpoint_type to private + added variable validation to var.rotation_interval_month Dec 22, 2022
@ocofaigh ocofaigh changed the title fix: updated the default value of endpoint_type to private + added variable validation to var.rotation_interval_month fix: updated the default value of var.endpoint_type to private + added variable validation to var.rotation_interval_month Dec 22, 2022
@ocofaigh ocofaigh changed the title fix: updated the default value of var.endpoint_type to private + added variable validation to var.rotation_interval_month fix: added variable validation to var.rotation_interval_month Dec 22, 2022
Copy link
Member

@MatthewLemmond MatthewLemmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, everything looks good otherwise

variables.tf Outdated Show resolved Hide resolved
@ocofaigh ocofaigh merged commit bf849d0 into main Dec 22, 2022
@ocofaigh ocofaigh deleted the cleanup branch December 22, 2022 15:06
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants