Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multipe public route tables #1020

Closed
pedrojflores opened this issue Dec 11, 2023 · 9 comments · Fixed by #1051
Closed

support for multipe public route tables #1020

pedrojflores opened this issue Dec 11, 2023 · 9 comments · Fixed by #1051

Comments

@pedrojflores
Copy link

Is your request related to a new offering from AWS?

Yes. This is to better support a vpc hosting an AWS Firewall infrastructure where you need to route traffic from public subnets to an unique firewall interface on a specific az.

Is your request related to a problem? Please describe.

Yes. Due to this limitation I can't use this module to build my AWS Firewall Egress vpcs.

Describe the solution you'd like.

I would like an option that when set a unique route table gets created per public subnet (per az). Same support the module has for private subnets.

@nirmesika
Copy link

add support for adding routes to public and private subnets.

@piartz
Copy link

piartz commented Jan 4, 2024

@pedrojflores I have created a pull request, please let me know if this is what you were looking for, and we can wait for a review.
#1025

Feliz año 2024!

Copy link

github-actions bot commented Feb 4, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 4, 2024
@piartz
Copy link

piartz commented Feb 7, 2024

Pumping up this issue as it is not stale anymore

@KevinSnyderCodes
Copy link
Contributor

I've also created a pull request that expands this to both public and intra subnets: #1051

I punted on the other subnet types as their logic was a bit more complex, but it should be possible to support multiple route tables for all subnet types.

Copy link

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 6, 2024
@KevinSnyderCodes
Copy link
Contributor

Not stale

@antonbabenko
Copy link
Member

This issue has been resolved in version 5.8.0 🎉

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants