Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated string interpolation in resource #97

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

yyarmoshyk
Copy link
Contributor

Description

Removing "${ sequence from the start and the }" aws_s3_bucket.this[0].arn to silence the warning about non-constant expressions provided via interpolation syntax

Motivation and Context

Tired of the following message:
Terraform 0.11 and earlier required all non-constant expressions to be
provided via interpolation syntax, but this pattern is now deprecated. To
silence this warning, remove the "${ sequence from the start and the }"
sequence from the end of this expression, leaving just the inner expression.

Breaking Changes

Does this break backwards compatibility with the current major version? No

How Has This Been Tested?

  • I did this change locally and applied the infrastructure update referencing the local version of the code. Warning didn't show up

@antonbabenko antonbabenko changed the title Update main.tf chore: Updated string interpolation in resource Jun 18, 2021
@antonbabenko antonbabenko merged commit c4de104 into terraform-aws-modules:master Jun 18, 2021
@antonbabenko
Copy link
Member

Thank you, Yaroslav! v2.5.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants