From 03784ced4d63456d281dc509560ec8e9763f4feb Mon Sep 17 00:00:00 2001 From: Guillaume Pontbriand <107485180+gpontbriand@users.noreply.github.com> Date: Tue, 28 Mar 2023 15:03:26 -0400 Subject: [PATCH 1/3] Add output for listener_endpoint "Specifies the listener connection endpoint for SQL Server Always On" --- modules/db_instance/outputs.tf | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/db_instance/outputs.tf b/modules/db_instance/outputs.tf index 003ebb47..5b622634 100644 --- a/modules/db_instance/outputs.tf +++ b/modules/db_instance/outputs.tf @@ -28,6 +28,11 @@ output "db_instance_endpoint" { value = try(aws_db_instance.this[0].endpoint, "") } +output "db_listener_endpoint" { + description = "Specifies the listener connection endpoint for SQL Server Always On" + value = try(aws_db_instance.this[0].listener_endpoint, "") +} + output "db_instance_engine" { description = "The database engine" value = try(aws_db_instance.this[0].engine, "") From 2250c710c151abe6118ab9c2efbf808b380e8dcf Mon Sep 17 00:00:00 2001 From: Guillaume Pontbriand <107485180+gpontbriand@users.noreply.github.com> Date: Tue, 28 Mar 2023 15:35:27 -0400 Subject: [PATCH 2/3] Add missing output --- outputs.tf | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/outputs.tf b/outputs.tf index ace7495d..f9716d18 100644 --- a/outputs.tf +++ b/outputs.tf @@ -28,6 +28,11 @@ output "db_instance_endpoint" { value = module.db_instance.db_instance_endpoint } +output "db_listener_endpoint" { + description = "Specifies the listener connection endpoint for SQL Server Always On" + value = module.db_instance.db_listener_endpoint +} + output "db_instance_engine" { description = "The database engine" value = module.db_instance.db_instance_engine From 60be44e82e9d770ce859748d120ac46c3a88d485 Mon Sep 17 00:00:00 2001 From: Bryant Biggs Date: Tue, 2 May 2023 20:42:50 -0400 Subject: [PATCH 3/3] chore: Update docs and fix formatting to pass CI checks --- .pre-commit-config.yaml | 2 +- README.md | 1 + modules/db_instance/README.md | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 071427d7..f6f54bb6 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/antonbabenko/pre-commit-terraform - rev: v1.77.1 + rev: v1.78.0 hooks: - id: terraform_fmt - id: terraform_validate diff --git a/README.md b/README.md index 1185b453..640fd1c1 100644 --- a/README.md +++ b/README.md @@ -350,6 +350,7 @@ Users have the ability to: | [db\_instance\_resource\_id](#output\_db\_instance\_resource\_id) | The RDS Resource ID of this instance | | [db\_instance\_status](#output\_db\_instance\_status) | The RDS instance status | | [db\_instance\_username](#output\_db\_instance\_username) | The master username for the database | +| [db\_listener\_endpoint](#output\_db\_listener\_endpoint) | Specifies the listener connection endpoint for SQL Server Always On | | [db\_option\_group\_arn](#output\_db\_option\_group\_arn) | The ARN of the db option group | | [db\_option\_group\_id](#output\_db\_option\_group\_id) | The db option group id | | [db\_parameter\_group\_arn](#output\_db\_parameter\_group\_arn) | The ARN of the db parameter group | diff --git a/modules/db_instance/README.md b/modules/db_instance/README.md index c9c535f0..4a2e0952 100644 --- a/modules/db_instance/README.md +++ b/modules/db_instance/README.md @@ -126,6 +126,7 @@ No modules. | [db\_instance\_resource\_id](#output\_db\_instance\_resource\_id) | The RDS Resource ID of this instance | | [db\_instance\_status](#output\_db\_instance\_status) | The RDS instance status | | [db\_instance\_username](#output\_db\_instance\_username) | The master username for the database | +| [db\_listener\_endpoint](#output\_db\_listener\_endpoint) | Specifies the listener connection endpoint for SQL Server Always On | | [enhanced\_monitoring\_iam\_role\_arn](#output\_enhanced\_monitoring\_iam\_role\_arn) | The Amazon Resource Name (ARN) specifying the monitoring role | | [enhanced\_monitoring\_iam\_role\_name](#output\_enhanced\_monitoring\_iam\_role\_name) | The name of the monitoring role |