Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore changes to last_restorable_time #476

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

bathomas
Copy link
Contributor

@bathomas bathomas commented Feb 6, 2023

Description

Changes to last_restorable_time were ignored in v4. See #356. This seems to have been reintroduced in v5.0.0.

Motivation and Context

Drift detection on TFCB flags a health warning when the restorable time changes.

Breaking Changes

I don't believe there are breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit acb3d51 into terraform-aws-modules:master Feb 7, 2023
antonbabenko pushed a commit that referenced this pull request Feb 7, 2023
### [5.3.1](v5.3.0...v5.3.1) (2023-02-07)

### Bug Fixes

* Ignore changes to last_restorable_time ([#476](#476)) ([acb3d51](acb3d51))
@antonbabenko
Copy link
Member

This PR is included in version 5.3.1 🎉

@daroga0002
Copy link
Contributor

looks this PR introduced warning:

Warning: Redundant ignore_changes element

  on .terraform/modules/customer.db/modules/db_instance/main.tf line 32, in resource "aws_db_instance" "this":
  32: resource "aws_db_instance" "this" {

Adding an attribute name to ignore_changes tells Terraform to ignore future
changes to the argument in configuration after the object has been created,
retaining the value originally configured.

The attribute latest_restorable_time is decided by the provider alone and
therefore there can be no configured value to compare with. Including this
attribute in ignore_changes has no effect. Remove the attribute from
ignore_changes to quiet this warning.

(and one more similar warning elsewhere)

terraform version: "1.3.7"
registry.terraform.io/hashicorp/aws: "4.53.0"

@bryantbiggs
Copy link
Member

I think now I remember why we removed that 😅

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants