-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add engine
and engine_version_actual
outputs
#404
feat: Add engine
and engine_version_actual
outputs
#404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you also add one more related output - engine_version_actual
?
engine
outputengine
and engine_version
output
@antonbabenko Added the |
engine
and engine_version
outputengine
and engine_version_actual
outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @stefan-matic - looks great
## [4.4.0](v4.3.0...v4.4.0) (2022-05-27) ### Features * Add `engine` and `engine_version_actual` outputs ([#404](#404)) ([00b9858](00b9858))
This PR is included in version 4.4.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Added new outputs for
engine
andengine_version_actual
in module, examples, and README.Motivation and Context
The output value for
engine
is needed when creating Secrets Manager RDS Credentials in the same way how it's created via the console. The keys that are created by default through the console are:When replicating the same approach via Terraform only the engine cannot be sourced using outputs.
Breaking Changes
No.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request