feat: Add restore_to_point_in_time support for databases #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mysql Add restore_to_point_in_time support for databases others than mysql Signed-off-by: Reinhard Luediger <reinhardluediger@gmail.com>
khdevel
reviewed
Jun 24, 2021
modules/db_instance/main.tf
Outdated
| restore_time = restore_to_point_in_time.value.restore_time | ||
| source_db_instance_identifier = lookup(restore_to_point_in_time.value, "source_db_instance_identifier", null) | ||
| source_dbi_resource_id = lookup(restore_to_point_in_time.value, "source_dbi_resource_id", null) | ||
| use_latest_restorable_time = lookup(restore_to_point_in_time.value, "use_latest_restorable+time", null) |
There was a problem hiding this comment.
There is a typo here - we have use_latest_restorable+time but should be use_latest_restorable_time
|
How do you see this implementation? When will it be available in standard release? @antonbabenko |
antonbabenko
changed the title
|
v3.2.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds restore_to_point_in_time support for databases others than mysql.
Motivation and Context
When you have to perform a point in time recovery on a AWS RDS Instance it will always create a new instance.
In order to get this new instance under control of terraform I would use the same terraform-aws-module that was used to create the source database. The existing module is using the aws_db_instance resource of the aws provider. Because this resource supports already the restore_to+point_in_time Input this module should support it as well.
Breaking Changes
No braking changes.
How Has This Been Tested?
We tested it with the following steps