Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix regression with aws_cloudwatch_log_group resource after upgr… #130

Conversation

parmouraly
Copy link

@parmouraly parmouraly commented Mar 1, 2021

…ade of AWS provider 3.0 (#106)

Description

Just cherry picked your commit for the 4.X version.

Motivation and Context

Deals with the log group missing wildcard regression for folk who want to upgrade to provider > 3 but are still in TF12

Breaking Changes

No

How Has This Been Tested?

Ran plan on my organisation repo and the log-group policy resource correctly ends in :* as it was before.

@parmouraly
Copy link
Author

parmouraly commented Mar 1, 2021

Hey @antonbabenko this is just a cherry pick of your commit, can we please merge and release a new version for the TF12 compatibility stream. Many thanks

@antonbabenko antonbabenko merged commit 8c86c26 into terraform-aws-modules:terraform012 Mar 1, 2021
@antonbabenko
Copy link
Member

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants