feat: Improve slack message formatting for generic messages #124
Conversation
|
Hello @antonbabenko, would you be able to review this PR? |
|
@chrissng Sorry, I can't promise that I find time for this so soon. Maybe someone else from @terraform-aws-modules/triage-supporters can look into this PR (and in this repo)? |
|
@chrissng Looks good, is it possible to ask you to add some unit tests for this? |
|
Sure! I have added a test case which contains an example of a typical AWS event.
|
|
Awesome, if you can just rebase your branch we are good to go! |
|
Thanks @chrissng and @DrFaust92 for the review! v4.11.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Improves readability of generic messages sent by AWS services.
Before this PR:
With this PR:
Motivation and Context
Currently messages other than the ones from Cloudwatch are sent as slack messages in verbatim as json strings. I thought by formatting the messages it would enhance its readability. For instance, this happens to messages received from AWS DMS events.
Breaking Changes
No breaking changes
How Has This Been Tested?
Ran existing test according to test setup instructions. Existing tests fixtures already provide coverage and this change only affects the formatting of the default notification.