fix: Use dynamic partition value #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to interpolate resource arns to use local.partition instead of hardcoded value of "aws" to prevent breaking non-commercial use cases.
mcamick
changed the title
bryantbiggs
changed the title
bryantbiggs
approved these changes
Oct 22, 2024
bryantbiggs
merged commit 9986b50
into
terraform-aws-modules:master
35 of 37 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Oct 22, 2024
## [5.47.1](v5.47.0...v5.47.1) (2024-10-22) ### Bug Fixes * Use dynamic partition value ([#532](#532)) ([9986b50](9986b50))
|
This PR is included in version 5.47.1 🎉 |
This was referenced Oct 22, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to interpolate resource arns to use local.partition instead of hardcoded value of "aws" to prevent breaking non-commercial use cases.
Description
Updated previously changed values to use local.partition instead of hardcoded 'aws' reference.
Motivation and Context
Resolves #531
Breaking Changes
This shouldn't be a breaking change and is using a pattern that exists other places in the policies.tf file.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsTested with project that was previously broken by a previous update to validate fix.
pre-commit run -aon my pull requestRan
