-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new IAM module iam-eks-role #179
feat: Add new IAM module iam-eks-role #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Minor comments.
examples/iam-eks-role/main.tf
Outdated
|
||
module "iam_eks_role" { | ||
source = "terraform-aws-modules/iam/aws//modules/iam-eks-role" | ||
version = "~> 4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And remove version
Thanks for the review @antonbabenko! I think I've addressed everything 🙏 |
## [4.9.0](v4.8.0...v4.9.0) (2022-01-14) ### Features * Add new IAM module iam-eks-role ([#179](#179)) ([61cf542](61cf542))
This PR is included in version 4.9.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adding a new, user-friendly module that is specifically for AWS EKS users.
Motivation and Context
Currently EKS users would use the module
iam-assumable-role-with-oidc
but the way it is structured/implemented is quite confusing:ServiceAccount
per multiple clusters asprovider_urls
andoidc_fully_qualified_subjects
are separate.oidc_fully_qualified_subjects
are and shouldn't need to.data
resource to get the OIDC URL of each clusterThis module solves these in a nice clean way for EKS users by using a data resource inside the module and having a one-to-many relationship from
provider_url
tooidc_fully_qualified_subjects
but implemented simply asEKS cluster name
toServiceAccount
, like this:Breaking Changes
It's a new module so no breaking changes.
How Has This Been Tested?
examples/*
projects.