fix: Step function enrichment #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add variable to allow only pipe role creation
|
@antonbabenko could you have a look, please |
antonbabenko
requested changes
Jan 23, 2025
| @@ -33,7 +33,7 @@ locals { | |||
| matching_services = ["lambda"] | |||
| }, | |||
| step_functions = { | |||
| values = [v.target, try(aws_cloudwatch_event_api_destination.this[v.enrichment].arn, null)], | |||
| values = [v.target, try(v.enrichment, null)], | |||
There was a problem hiding this comment.
because the matching service is states and that can never be fulfilled by an api destination.
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
approved these changes
Jan 28, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Jan 28, 2025
## [3.14.3](v3.14.2...v3.14.3) (2025-01-28) ### Bug Fixes * Step function enrichment ([#149](#149)) ([8e1c345](8e1c345))
|
This PR is included in version 3.14.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The new variable allows to create the iam role only for pipe, for the cases where nothing else is created besides pipes, as for now you would end up with an additional role which is not needed
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request