Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed ssl_certificate_id argument name #32

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

gstlt
Copy link
Contributor

@gstlt gstlt commented Mar 31, 2020

Description

Documentation update

Motivation and Context

Spotted wrong argument name for ssl in README.md

Breaking Changes

None

How Has This Been Tested?

No tests needed

@antonbabenko antonbabenko changed the title Minor update of README.md - certificate id argument name docs: Fixed ssl_certificate_id argument name Mar 31, 2020
@antonbabenko antonbabenko merged commit 18d8b91 into terraform-aws-modules:master Mar 31, 2020
@gstlt
Copy link
Contributor Author

gstlt commented Mar 31, 2020

@antonbabenko Thanks!
ps. Some contribution doc would be great, got confused when test failed. Cheers!

@antonbabenko
Copy link
Member

Thanks @gstlt !

Yes, it should be coming in the near future (I hope). There is a meta-repository for such things across all terraform-aws-modules repositories - https://github.com/terraform-aws-modules/meta . I have just created an issue there.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants