Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore changes in the ebs_block_device #46

Conversation

danihodovic
Copy link
Contributor

@danihodovic danihodovic commented Sep 3, 2018

Any change in the ebs block device currently triggers re-creation of
this resource which I assume is not intended. In turn any attached
block device will also be re-created because the instance is created
creating a loop of resource creation each time terraform is applied.

Workaround by ignoring these changes as suggested in:

hashicorp/terraform-provider-aws#1297 (comment)

Any change in the ebs block device currently triggers re-creation of
this resource which I assume is not intended.

Workaround by ignoring these changes as suggested in:

hashicorp/terraform-provider-aws#1297 (comment)
@antonbabenko
Copy link
Member

Yes, the change you are proposing makes sense, I will merge this and add a sentence explaining the need to use aws_volume_attachment resource to README.

Thanks for the contribution!

@antonbabenko antonbabenko merged commit 403ddf4 into terraform-aws-modules:master Sep 4, 2018
@danihodovic
Copy link
Contributor Author

Thanks for the quick review!

@danihodovic danihodovic deleted the ignore-changes-ebs-block-device branch September 4, 2018 10:11
@antonbabenko
Copy link
Member

v1.11.0 has been released.

Sebor pushed a commit to Sebor/terraform-aws-ec2-instance that referenced this pull request Aug 6, 2020
Any change in the ebs block device currently triggers re-creation of
this resource which I assume is not intended.

Workaround by ignoring these changes as suggested in:

hashicorp/terraform-provider-aws#1297 (comment)
Sebor pushed a commit to Sebor/terraform-aws-ec2-instance that referenced this pull request Aug 6, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants