Skip to content

Conversation

enver
Copy link
Contributor

@enver enver commented Jun 10, 2022

Description

Fixes #43

Motivation and Context

User should be able to specify default ok_action and insufficient_data_actions for cis-alarms module.

Breaking Changes

None, added variables have default values set for backward compatibility.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I've validated changes on my own project, testing new feature and backward compatibility.
  • I have executed pre-commit run -a on my pull request

@enver enver changed the title Add option to specify default ok no data actions feat: Add option to specify default ok no data actions Jun 10, 2022
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 15, 2022
@enver
Copy link
Contributor Author

enver commented Jul 18, 2022

@antonbabenko Could you please review it?

@antonbabenko antonbabenko merged commit fdb39b7 into terraform-aws-modules:master Jul 18, 2022
antonbabenko pushed a commit that referenced this pull request Jul 18, 2022
## [3.3.0](v3.2.0...v3.3.0) (2022-07-18)

### Features

* Add option to specify default ok no data actions ([#44](#44)) ([fdb39b7](fdb39b7))
@antonbabenko
Copy link
Member

This PR is included in version 3.3.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ok_action and insufficient_data_actions variables for cis-alarms module
2 participants