Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change default deployment percentages when using EFS to allow updates to succeed #399

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Change default deployment percentages when using EFA to allow updates to succeed

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs force-pushed the fix/updates-with-efs branch from 526a183 to 85f2c1b Compare March 4, 2024 14:40
@bryantbiggs bryantbiggs requested a review from antonbabenko March 4, 2024 14:42
@antonbabenko antonbabenko changed the title fix: Change default deployment percentages when using EFA to allow updates to succeed fix: Change default deployment percentages when using EFS to allow updates to succeed Mar 4, 2024
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. LGTM

@bryantbiggs bryantbiggs merged commit 834bc0d into terraform-aws-modules:master Mar 4, 2024
10 checks passed
@bryantbiggs bryantbiggs deleted the fix/updates-with-efs branch March 4, 2024 21:54
antonbabenko pushed a commit that referenced this pull request Mar 4, 2024
### [4.2.1](v4.2.0...v4.2.1) (2024-03-04)

### Bug Fixes

* Change default deployment percentages when using EFS to allow updates to succeed ([#399](#399)) ([834bc0d](834bc0d))
@antonbabenko
Copy link
Member

This PR is included in version 4.2.1 🎉

Copy link

github-actions bot commented Apr 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redeploying fargate atlantis task always breaks
2 participants