fix: Cannot specify more than one extra_container_definitions #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Oct 19, 2022
versions.tf
Outdated
| @@ -1,5 +1,5 @@ | |||
| terraform { | |||
| required_version = ">= 0.13.1" | |||
| required_version = ">= 1.3.0" | |||
There was a problem hiding this comment.
This is a breaking change and we do not want to push users to the bleeding edge as it will reduce adoption
bryantbiggs
requested changes
Oct 19, 2022
|
Makes sense about limiting the impact of the required terraform version. I think I've found another way to do it without needing all the explicit typing. I'll update this PR. |
…ed list comparison issues.
bryantbiggs
approved these changes
Oct 22, 2022
|
Thank you @dynamike |
antonbabenko
pushed a commit
that referenced
this pull request
Oct 22, 2022
### [3.22.1](v3.22.0...v3.22.1) (2022-10-22) ### Bug Fixes * Cannot specify more than one extra_container_definitions ([#314](#314)) ([7c1ad25](7c1ad25))
|
This PR is included in version 3.22.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves issues defined in #269 when trying to pass in multiple container definitions into
extra_container_definitions. The main issue is Terraform's requirement for exact matching objects when untyping a variable asanyMore detail is defined in hashicorp/terraform#26265. For the time being, this PR untypes the variable to get around the error. A more robust solution would leverage required and optional attributes to define a container definition.Motivation and Context
Resolves #269, which seems like an increasingly common issue with more and more sidecar containers used for things like log routing and observability.
Breaking Changes
There shouldn't be any breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request