feat: Support ALB authentication using AWS Cognito #102
Conversation
There was a problem hiding this comment.
Thanks for the PR.
I have a few notes for you to update if you can:
- ALB module has support for all actions including
authenticate-cognito(see: https://github.com/terraform-aws-modules/terraform-aws-alb/blob/567bf7b2e2455651b4973164a6e8c80101c816e7/examples/complete-alb/main.tf#L137-L156 ) - Remove provider
githubblock and make it as an external/conditional dependency, if really necessary. - Add example in examples folder showing complete integration - call Atlantis module and create required AWS Cognito resources.
- Rebase this PR. The master branch has been updated since you created this.
|
I'll get these updated. Thanks for the review! |
Mk cognito redo
dynamike
changed the title
dynamike
changed the title
|
@antonbabenko I think I've updated everything based off #123 and #122 . Did you still want me to put and a usage example in |
README.md
Outdated
| ``` | ||
|
|
||
| Read more in [this post](https://medium.com/@alsmola/alb-authentication-with-g-suite-saml-using-cognito-858e35564dc8) and a helpful [SAML Cognito Terraform module](https://github.com/alloy-commons/alloy-open-source/tree/master/terraform-modules/gsuite-saml-cognito). |
There was a problem hiding this comment.
medium.com is a paid service and not everyone can read that post. It would be great if you include relevant information into README of your module so that everything is in one place. And remove the link from this module to the blog post (unless you can find it available on free resource).
There was a problem hiding this comment.
I tried cleaning up this section and pointed to the example usage for the gsuite-saml-cognito module. Let me know if you have other thoughts.
There was a problem hiding this comment.
Have you pushed your changes? I don't see them.
There was a problem hiding this comment.
sigh. Sorry about that. They should be pushed now.
|
No need to update examples. I left couple small README-related comments for your review, and after those are fixed I will merge. |
|
Great! Thank you very much. v2.17.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR will allow this module to enforce authentication at the ALB, which is helpful when running Atlantis on the public internet. AWS Cognito is able to connect to your favorite identity provider using SAML.