Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option enforce_security_group_inbound_rules_on_private_link_traffic #332

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

ricardoleal
Copy link
Contributor

@ricardoleal ricardoleal commented Dec 11, 2023

Description

Add enforce_security_group_inbound_rules_on_private_link_traffic to aws_lb

Motivation and Context

When using Security Group for network load balancers there is a need to configure whether the inbound rules are enforced for PrivateLink traffic.

hashicorp/terraform-provider-aws#33766
hashicorp/terraform-provider-aws#33767

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few updates and we'll need to wait for the next release of the provider

versions.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
ricardoleal and others added 2 commits December 11, 2023 14:59
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 33feec8 into terraform-aws-modules:master Dec 22, 2023
8 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 22, 2023
## [9.3.0](v9.2.0...v9.3.0) (2023-12-22)

### Features

* Add option enforce_security_group_inbound_rules_on_private_link_traffic ([#332](#332)) ([33feec8](33feec8))
@antonbabenko
Copy link
Member

This PR is included in version 9.3.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants