fix: Explicitly setting http_tcp_listener.action_type to forward fails #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarodiv
changed the title
Jarodiv
changed the title
Jarodiv
changed the title
Jarodiv
changed the title
added 3 commits
March 20, 2023 10:05
…listener.action_type-to-forward-fails
…listener.action_type-to-forward-fails
…listener.action_type-to-forward-fails
|
This PR has been automatically marked as stale because it has been open 30 days |
|
'Keep alive' comment |
|
It looks like this is going to help. Thanks @Jarodiv for |
antonbabenko
approved these changes
Jun 6, 2023
|
@Jarodiv Thank you very much for this improvement! |
antonbabenko
pushed a commit
that referenced
this pull request
Jun 6, 2023
### [8.6.1](v8.6.0...v8.6.1) (2023-06-06) ### Bug Fixes * Explicitly setting http_tcp_listener.action_type to forward fails ([#281](#281)) ([b6cf424](b6cf424))
|
This PR is included in version 8.6.1 🎉 |
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
http_tcp_listeneraccept"forward"as explicitly set value.Motivation and Context
If you need to set the value of
action_typeexplicitly (e.g. to make redirecting optional), there is no working way to do so.This solves #280
Breaking Changes
There should be no negative effect on backwards compatibility with the current major version.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request