Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for target group protocol_version #187

Merged
merged 4 commits into from
Apr 16, 2021

Conversation

jasonwalsh
Copy link
Contributor

@jasonwalsh jasonwalsh commented Mar 16, 2021

Description

This pull request adds support for the protocol_version argument of the aws_lb_target_group resource.

Resolves #179

Motivation and Context

hashicorp/terraform-provider-aws#17534

Breaking Changes

N/A

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@alfoudari
Copy link

I have also tried this PR and verified it works.

@antonbabenko antonbabenko merged commit 6ae596b into terraform-aws-modules:master Apr 16, 2021
@antonbabenko
Copy link
Member

Thank you for this update!

v5.16.0 has been just released.

@adelwin
Copy link

adelwin commented Oct 23, 2021

Sorry if this is a silly question, but what's the possible values for protocol_version?
I know HTTP1 and HTTP2, and what's the value for gRPC? "gRPC" ? or "GRPC"? or something else?
I kinda have the need to build one with it.

@antonbabenko
Copy link
Member

@adelwin According to this PR - https://github.com/hashicorp/terraform-provider-aws/pull/17534/files#diff-9d51a42afeb9375d684c4fccd83c6168e3da5091817e085829e4f76711ead008R1910-R1911

You should specify:

  protocol         = "HTTP"
  protocol_version = "GRPC"

I didn't try it myself.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for target group "protocol_version"
4 participants