Removes the provider setting and improves the Readme #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaozhu36
requested changes
Nov 15, 2021
README.md
Outdated
| | Name | Version | | ||
| |------|---------| | ||
| | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.12.0 | | ||
| | <a name="requirement_alicloud"></a> [alicloud](#requirement\_alicloud) | >= 1.56.0 |
There was a problem hiding this comment.
从上面157行看，这个module的最小版本是 1.77.0
| @@ -154,11 +154,78 @@ If you want to store kube config and other certificates after the cluster create | |||
|
|
|||
| Terraform version | |||
| ----------------- | |||
| Terraform version 0.12.0 or newer and Provider version 1.77.0 or newer are required for this example to work. | |||
There was a problem hiding this comment.
既然已经移除掉了provider，那么readme上方的Usage和Inputs中相关的字段内容也要去掉
xiaozhu36
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified author contact information