Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unwrap from rust module #74

Open
panosfol opened this issue Jul 8, 2024 · 0 comments
Open

Removing unwrap from rust module #74

panosfol opened this issue Jul 8, 2024 · 0 comments
Assignees
@charmitro
Labels
good first issue Good for newcomers help wanted Extra attention is needed rust-libs

Comments

@panosfol
Copy link
Collaborator

panosfol commented Jul 8, 2024

Calling unwrap will prevent us from utilizing mutexes to introduce thread safety in our rust module, since a thread that panicked will be unable to unlock the mutex.

The unwrap calls should be replaced with actually matching the results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charmitro charmitro

Labels
good first issue Good for newcomers help wanted Extra attention is needed rust-libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rust: email: replace unwrap with proper error handling terra-sync/cnc
2 participants
@charmitro @panosfol