Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Package]: Squashfs Tools #22959

Open
4 of 8 tasks
mio-19 opened this issue Jan 18, 2025 · 8 comments · May be fixed by #22974
Open
4 of 8 tasks

[Package]: Squashfs Tools #22959

mio-19 opened this issue Jan 18, 2025 · 8 comments · May be fixed by #22974
Labels
package request A new package was requested

Comments

@mio-19
Copy link

mio-19 commented Jan 18, 2025

Why is it worth to add this package?

I want tools like unsquashfs

Home page URL

No response

Source code URL

https://github.com/plougher/squashfs-tools

Packaging policy acknowledgement

  • The project is actively developed.

  • The project has existing packages and is "well known".

  • Licensed under an open source license.

  • Not available through a language package manager: pip, npm, cpan, cargo, etc.

  • Not taking up too much disk space (< 100MiB per architecture, exceptions can be made)

  • Not duplicating the functionality of existing packages.

  • Not serving hacking, malware, phishing, spamming, spying, ddos functionality.

  • I certify that I have read Termux Packaging Policy and understand that my request will be denied if it is found lacking.

Additional information

No response
@mio-19 mio-19 added the package request A new package was requested label Jan 18, 2025
@twaik
Copy link
Member

twaik commented Jan 18, 2025

Duplicate of #6537.

@twaik twaik closed this as completed Jan 18, 2025
@mio-19
Copy link
Author

mio-19 commented Jan 18, 2025

It is not duplicate. -ng is a seperate package with different tools

@Biswa96
Copy link
Member

Biswa96 commented Jan 18, 2025

squashfs-tools and squashfs-tools-ng projects provide separate programs. Here is the list of programs from Alpine Linux.

  • squashfs-tools-ng
/ # apk info --contents squashfs-tools-ng
squashfs-tools-ng-1.3.2-r0 contains:
usr/bin/gensquashfs
usr/bin/rdsquashfs
usr/bin/sqfs2tar
usr/bin/sqfsdiff
usr/bin/tar2sqfs
  • squashfs-tools
/ # apk info --contents squashfs-tools
squashfs-tools-4.6.1-r1 contains:
usr/bin/mksquashfs
usr/bin/sqfscat
usr/bin/sqfstar
usr/bin/unsquashfs

I can try to add the package if it is allowed here.

@twaik twaik reopened this Jan 18, 2025
@Biswa96
Copy link
Member

Biswa96 commented Jan 18, 2025

I have tried to build it but I do not know how to the pthread_cancel workaround work.

restore.c:87:3: error: call to undeclared function 'pthread_cancel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
   87 |                 pthread_cancel(reader_thread);
      |                 ^
restore.c:87:3: note: did you mean 'pthread_once'?
/home/builder/.termux-build/_cache/android-r27c-api-24-v1/bin/../sysroot/usr/include/pthread.h:264:5: note: 'pthread_once' declared here
  264 | int pthread_once(pthread_once_t* _Nonnull __once, void (* _Nonnull __init_routine)(void));
      |     ^
1 error generated.

@twaik
Copy link
Member

twaik commented Jan 18, 2025

@Biswa96 https://github.com/termux/termux-packages/blob/master/x11-packages/tigervnc/tigervnc-1.9.0_common_os_Thread.cxx.patch

@Biswa96 Biswa96 linked a pull request Jan 18, 2025 that will close this issue
Open
@Biswa96
Copy link
Member

Biswa96 commented Jan 18, 2025

I tried to add that changes but mksquashfs process never stops. Please review the pull request.

example: mksquashfs path/to/dir file-name.sqfs

@mio-19
Copy link
Author

mio-19 commented Jan 19, 2025

I tried to add that changes but mksquashfs process never stops. Please review the pull request.

example: mksquashfs path/to/dir file-name.sqfs

This package is helpful even if only unsquashfs is working

@robertkirkman
Copy link
Contributor

robertkirkman commented Jan 29, 2025 •
edited
Loading

@Biswa96 Before March 28 2013 , squashfs-tools did not contain calls to pthread_cancel() or pthread_testcancel() .

I am not sure how to completely fix the present day version of squashfs-tools,

but, I created and tested this archaic squashfs-tools package for anyone it might help. This one does not have the hanging problem.

robertkirkman@0f21335

Caution

SECURITY NOTE
This version of squashfs-tools could possibly be vulnerable to CVE-2015-4645 or CVE-2015-4646, therefore it should not be used on untrusted inputs of any kind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package request A new package was requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

addpkg(main/squashfs-tools): 4.6.1 Biswa96/termux-packages
4 participants
@twaik @Biswa96 @robertkirkman @mio-19