fix: Mark view as important for AutoFill after requesting an AutoFill #4165
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AChep
changed the title
|
Fixes AChep/keyguard-app#594 |
Co-authored-by: @AChep <mail@artemchep.com> Co-authored-by: @agnostic-apollo <agnosticapollo@gmail.com>
agnostic-apollo
force-pushed
the
patch-1
branch
from
c6c2086
to
92208e7
Compare
|
Thanks for the fix. Makes sense, in the initial commit for AutoFill long ago, the view was marked as not important with a hardcoded value as it wasn't important at all times, hence I kept the logic in my last changes in c2d57f2, but now that we are dynamically setting autofill config, this is the way to go. I assume the keyguard-app wouldn't have been working even before my last changes. 8c80efb#diff-e8f482031a706124776cc4b4e81898127e6dd8dda09f1ffffa25eba7ff711f0aR23 p.s Please use commit message format guidelines in future. https://github.com/termux/termux-app#commit-messages-guidelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the view is still marked as not important even after requesting an autofill.