Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cario-SR3]Spring Boot 2.0.4 introduced a breaking Lombok change - Lombok 1.16.22 #833

Closed
1 task
btkousil opened this issue Sep 7, 2018 · 1 comment
Closed
1 task
Assignees

Comments

@btkousil
Copy link
Contributor

btkousil commented Sep 7, 2018

Description

projectlombok/lombok#1703

FEATURE: Private no-args constructor for @Data and @Value to enable deserialization frameworks (like Jackson) to operate out-of-the-box. Use lombok.noArgsConstructor.extraPrivate = false to disable this behavior.

Possible Solutions

  • Through lombok issue 1730, It is certain that there have a bug in using @Data and @NoArgsConstructor together which supported by Lombok v1.16.22. It reports an existing no-args constructor on such class .
  • SpringBoot v2.0.4 dependency management includes Lombok v1.16.22, which includes this bug causing compilation errors.
  • The bug was fixed in Lombok v1.18.0
  • The best solution is corrected this reference to v1.18.0 by SpringBoot
  • But SpringBoot didn't plan to update this recently,SpringBoot's suggestion is upgrade to V1.18.0 by ourselves.
  • SO we should corrected this in gfw's pom.xml by set Lombok Version to 1.18.0
  • After upgrading, our code does not need to be changed.
  • When SpringBoot update its dependency ,we can delete this version settings then

Affects Version/s

  • 5.X.X.RELEASE
  • 1.X.X.RELEASE

Fix Version/s

  • master

Final Solution

(To be written later by project member)

Issue Links

@btkousil
Copy link
Contributor Author

Deal this in tourreservatoin 585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants