Skip to content

Commit

Permalink
rust: abort on panic in all profiles
Browse files Browse the repository at this point in the history
Until rust-lang/rust#52652 is fixed,
unwinding on panic is potentially unsound in a mixed C/Rust codebase.

The codebase is supposed to be panic-free already, but just to be safe.

This started mattering at commit d1820c1.

Fixes #27199; bugfix on tor-0.3.3.1-alpha.
  • Loading branch information
cypherpunks committed Aug 18, 2018
1 parent 87aacbf commit fecd583
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
3 changes: 3 additions & 0 deletions changes/bug27199
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
o Minor bugfixes (rust):
- Abort on panic in all build profiles, instead of potentially unwinding
into C code. Fixes bug 27199; bugfix on 0.3.3.1-alpha.
10 changes: 10 additions & 0 deletions src/rust/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
[workspace]
members = ["tor_util", "protover", "smartlist", "external", "tor_allocate", "tor_rust"]

# Can remove panic="abort" when this issue is fixed:
# https://github.com/rust-lang/rust/issues/52652
[profile.dev]
panic = "abort"

[profile.release]
debug = true
panic = "abort"

[profile.test]
panic = "abort"

[profile.bench]
panic = "abort"

0 comments on commit fecd583

Please sign in to comment.