Allow the '-' in the expression key parser #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should |
|
@mavam I changed the code so '-' is not allowed as the first character any longer. The last commit moves the entire implementation of the parser to the |
mavam
requested changes
Aug 3, 2020
| auto operand | ||
| = parsers::data ->* to_data_operand | ||
| = (parsers::data >> !key_char) ->* to_data_operand |
There was a problem hiding this comment.
Is end-of-input (eoi) also "not a key char"?
That is, does it work when the operand is either LHS or RHS?
There was a problem hiding this comment.
eoi is not a char. If data consumed the last character, key_char will fail no matter what it is composed of.
mavam
reviewed
Aug 4, 2020
mavam
reviewed
Aug 4, 2020
mavam
reviewed
Aug 4, 2020
mavam
reviewed
Aug 4, 2020
tobim
force-pushed
the
topic/expression-key-dash
branch
from
7778e6c
to
2becb72
Compare
mavam
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.