-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Annotate schemas with #index=hash" #765
Conversation
77e8e34
to
64a5520
Compare
If we want to disable the hash index completely, we also need to disable the attribute inject heuristic in the Zeek parser. We should also write a changelog entry so users know why this index is disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but please address the changes requested by @tobim.
This reverts commit 9f656e8. When benchmarking, we discovered that the hash index introduces a huge performance regression for the `vast import suricata` command, due to a variant type being used as a key in a `flat_map`. Therefore, we're removing the hash indices until the underlying problem is fixed.
This reverts commit cc1b8e6. Remove hash indices due to performance regressions.
64a5520
to
36d9286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as is. Please apply the suggested cosmetic fixes.
36d9286
to
e0c62b3
Compare
This partially reverts commit 9f656e8.
When benchmarking, we discovered that the hash index introduces
a huge performance regression for the
vast import suricata
command, due to a variant type being used as a key in a
flat_map
.Therefore, we're removing the hash indices until the underlying
problem is fixed.