Fix plugin versions in prebuilt Docker images #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And, as a small added bonus, align the plugin versions of the Nix build with all other plugin versions by adding `--abbrev=10` to all other builds as well.
dominiklohmann
force-pushed
the
story/ch27693/plugin-version-fixups
branch
from
382430c
to
54284dc
Compare
tobim
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This fixes the plugin versions in our prebuilt Docker images by using
>-rather than>in the workflow file to avoid a newline in the middle of an env variable definition. And, as a small added bonus, align the plugin versions of the Nix build with all other plugin versions by adding--abbrev=10to all other builds as well.📝 Checklist
🎯 Review Instructions
Check Docker CI job: The variables should be set correctly now.