Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle malformed segments at startup #1820

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Gracefully handle malformed segments at startup #1820

merged 4 commits into from
Aug 4, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Aug 3, 2021 •
edited by mavam
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit by commit. Verify that the first commit makes the tests fail.

@tobim
Test unexpeted data in segments
66090a7
@tobim
Don't bail because of a bad segment
dcc1536 
... and properly log and exit if the entire segment store fails
to initialize.
@tobim
Add a changelog entry
41c2639
@tobim tobim added the bug Incorrect behavior label Aug 3, 2021
@tobim tobim requested a review from a team August 3, 2021 13:40
@mavam mavam requested a review from lava August 3, 2021 14:50
lava
lava approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@lava lava left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from some minor issues. I did not test locally, but the unit test should cover the issue as far as I can tell.

libvast/src/segment_store.cpp Outdated Show resolved Hide resolved
libvast/src/segment_store.cpp Show resolved Hide resolved
@tobim tobim enabled auto-merge August 4, 2021 14:23
@tobim tobim merged commit 367eb4c into master Aug 4, 2021
@tobim tobim deleted the story/ch27629/bad-segments branch August 4, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @lava