Restore unique IDs for partition-local stores #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
changed the title
lava
force-pushed
the
story/ch26808/partition-local-id-space
branch
4 times, most recently
from
38ce69c
to
2b663bd
Compare
tobim
requested changes
Aug 16, 2021
lava
force-pushed
the
story/ch26808/partition-local-id-space
branch
6 times, most recently
from
c98e79a
to
7ce5a45
Compare
* Add offset/events fields into partition and partition synopsis flatbuffers. * Store info about ids in the meta index. * Add optional 'ids' field to query to query for specific ids.
Since the store already handles this case correctly, we can simply delegate these kinds of queries forward.
lava
force-pushed
the
story/ch26808/partition-local-id-space
branch
from
7ce5a45
to
21416e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Restore the ability to use offsets/ids when working with partition-local stores. This should also make it possible to use
vast exploreandvast getin combination with custom store backends.📝 Checklist
🎯 Review Instructions
Review commit-by-commit. Some points worth considering:
optional<ids>instead of ids, to distinguish between "no ids given" and "the empty set of ids requested"?