Fix Docker image builds for arm64 #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch27201/docker-arm64
branch
from
90a3e0a
to
5774abd
Compare
mavam
approved these changes
Jul 13, 2021
dominiklohmann
force-pushed
the
story/ch27201/docker-arm64
branch
2 times, most recently
from
817501c
to
f2b84df
Compare
- `FindSSE.cmake` module that checks for availability of various SSE-related compiler flags. - Bug fixes in `base64.hpp` to account for the difference between char and signed char on some platforms, e.g., arm64. - Use GCC-8 specific version of `VAST_DISCARD_ARGS` for all GCC versions; the same issues occured for GCC-10.
dominiklohmann
force-pushed
the
story/ch27201/docker-arm64
branch
from
f2b84df
to
6bfe847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
FindSSE.cmakemodule that checks for availability of various SSE-related compiler flags.base64.hppto account for the difference between char and signed char on some platforms, e.g., arm64.VAST_DISCARD_ARGSfor all GCC versions; the same issues occured for GCC-10.📝 Checklist
🎯 Review Instructions
Reason about the changes I've made. Read the code changes carefully.