Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message about /dev/null-backend on startup #1754

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Fix error message about /dev/null-backend on startup #1754

merged 2 commits into from
Jul 5, 2021

Conversation

lava
Copy link
Member

@lava lava commented Jul 2, 2021 •
edited
Loading

📔 Description

Don't use VAST_WARN() while initializing the logger, which leads to a nasty-looking error message.

Also, fix a parser bug in the journald detection routine that would cause us to always mistakenly return "false".

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

mavam
mavam approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test locally, but the changeset makes sense.

dominiklohmann
dominiklohmann approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you add a user-facing changelog entry before merging?

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jul 5, 2021
@lava lava merged commit ab1ffab into master Jul 5, 2021
@lava lava deleted the topic/startup-log-error branch July 5, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lava @mavam @dominiklohmann