Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log rotation threshold option #1709

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Fix log rotation threshold option #1709

merged 2 commits into from
Jun 7, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

As noticed by @tobim, the option was unaccounted for. I took the opportunity to improve some log messages as well.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit-by-commit.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jun 7, 2021
@dominiklohmann dominiklohmann requested a review from a team June 7, 2021 08:03
@dominiklohmann
Fix vast.log-rotation-threshold
67b332d 
The option was erroneously ignored before this change and never taken
into consideration.
@dominiklohmann
Make logger startup error messages more consistent
8aa33c0
@dominiklohmann dominiklohmann force-pushed the topic/fix-log-rotation-threshold branch from fcbc529 to 8aa33c0 Compare June 7, 2021 08:04
lava
lava approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; didn't test it but it can't become brokener than now.

tobim
tobim approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The fix is trivial so I opted to skip a local test.

@dominiklohmann dominiklohmann merged commit 99826c1 into master Jun 7, 2021
@dominiklohmann dominiklohmann deleted the topic/fix-log-rotation-threshold branch June 7, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@lava lava lava approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominiklohmann @lava @tobim