Don't send dynamic type information to connecting sources #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
story/ch25395/type-registry-transforms
branch
from
a27e219
to
5d7897e
Compare
dominiklohmann
approved these changes
May 18, 2021
dominiklohmann
changed the title
The type registry in VAST knows two different sources of type information: On the one hand, layouts are described in schema files that are stored on disk and loaded when VAST is started. The schema files describe the *input* data format that is expected by the sources. On the other hand, the type registry would accumulate the layouts of all table slices going through the importer. Without transforms, each of these layouts must have been the input format of some source, so the type registry would redistribute them to newly registered sources. With transforms, this is no longer guaranteed, since both client and server input transformation might have been applied to the table slice. Conceptually, the idea of a source not being able to parse its own input and relying on information from other, independent sources to do so is also quite weird. So from now on, we only forward the statically configured type information from the schema files to connecting sources.
lava
force-pushed
the
story/ch25395/type-registry-transforms
branch
from
5d7897e
to
f985e3b
Compare
|
Merging this without waiting for CI because the nix-prefetch-github package seems broken. Fwiw, I can reproduce the error locally: And I confirmed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
📝 Checklist
🎯 Review Instructions