Fix exporter.selectivity for idle periods #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now correctly set the `exporter.selectivity` metrics to 1.0 for idle periods instead of NaN.
JSON does not support `NaN`, `-NaN`, `inf`, and `-inf`. We render these values as `null` now.
dominiklohmann
force-pushed
the
topic/query-selectivity-nan
branch
from
d696c4f
to
cd950f2
Compare
dominiklohmann
commented
Apr 23, 2021
My local clang-format 12 disagrees with the CI's clang-format 11 here, but I consider this one a bug in clang-format 12.
tobim
reviewed
Apr 23, 2021
tobim
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Let's not print NaN in JSON.
📝 Checklist
🎯 Review Instructions
n/t