-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use individual files for changelog entries #1559
Use individual files for changelog entries #1559
Conversation
e91908d
to
165c826
Compare
b3bcf6f
to
48729fa
Compare
Is this adding a separate commit to master with every merge? |
For every merge that adds a changelog entry, yes. The alternative would be not to have a readable changelog file in the repository that we can link to. That we do regularly, hence the workflow. |
How about we just update the changelog with every release? It wouldn't change the logic you have in place, but reduce commit churn by quite a bit. Or an alternative: amend the merge commit. |
I don't see the issue, really. It's one commit per merge immediately after merging a PR, which is less than one a day. It really doesn't add much noise. We use a pinned VAST version internally that is not tied to our release cycle. If we update on every release only, we lose the ability to just click on the submodule and easily see the most recent changes.
Not an option. Let's not get into the business of force-pushing to our default branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer-reviewed with @tobim.
ec150c7
to
4b17019
Compare
4b17019
to
d0067cc
Compare
📔 Description
This helps avoid merge conflicts in the CHANGELOG.md file by generating it.
📝 Checklist
🎯 Review Instructions
Commit-by-commit.