Move PCAP import/export into a plugin #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
4 times, most recently
from
4bb247b
to
b878595
Compare
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
5 times, most recently
from
3211508
to
0ad4332
Compare
dominiklohmann
commented
Apr 15, 2021
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
from
fbdb2f1
to
d51d62d
Compare
This (rather large) commit creates two new plugin types, namely `reader_plugin` and `writer_plugin`, and creates a PCAP plugin that implements both. Additionally, it fixes unit tests for plugins, which were unable to actually use the plugin up until now.
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
from
d51d62d
to
9dcd33c
Compare
tobim
requested changes
Apr 16, 2021
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
from
ac9b20f
to
9a531f2
Compare
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
2 times, most recently
from
974a6f9
to
7035e3b
Compare
dominiklohmann
force-pushed
the
story/ch24761/pcap-plugin
branch
from
7035e3b
to
9460708
Compare
tobim
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This (rather large) commit creates two new plugin types, namely
reader_pluginandwriter_plugin, and creates a PCAP plugin that implements both. Additionally, it fixes unit tests for plugins, which were unable to actually use the plugin up until now.📝 Checklist
🎯 Review Instructions
File-by-file. Ideally this is peer-reviewed in a call.