Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for projections #1531

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Small fixes for projections #1531

merged 7 commits into from
Apr 7, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Apr 7, 2021 •
edited
Loading

📔 Description

  • Fix the projection index validity check
  • Extend the suricata.dns schema
  • Fix projections for lists and maps
  • Remove a superfluous comparison of unsigned

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

By commit.

@tobim tobim added maintenance Tasks for keeping up the infrastructure bug Incorrect behavior labels Apr 7, 2021
@tobim tobim changed the title Small fixes for projections. Small fixes for projections Apr 7, 2021
@tobim tobim force-pushed the story/ch24399/list-projections branch from 00fa575 to 02fd0fd Compare April 7, 2021 08:14
dominiklohmann
dominiklohmann approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good modulo two small things:

  • Please add a projection unit tests with more columns in the projection than rows in the slice
  • Please add a changelog entry for the Suricata schema change and adapt the integration test baseline accordingly

Approving as is, but please address before merging.

@tobim tobim force-pushed the story/ch24399/list-projections branch from 7dc527a to f5656a3 Compare April 7, 2021 09:50
@tobim tobim merged commit 8b212a2 into master Apr 7, 2021
@tobim tobim deleted the story/ch24399/list-projections branch April 7, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @dominiklohmann