Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the disk-monitor a singleton component #1495

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Make the disk-monitor a singleton component #1495

merged 3 commits into from
Mar 25, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Mar 25, 2021 •
edited
Loading

📔 Description

This fixes a bug that blocks the server process from exiting after a shutdown was initiated.

📝 Checklist

  • All user-facing changes have changelog entries.

@tobim
Make the disk-monitor a singleton component
d55edaa 
This fixes a bug that blocks the server process from exiting after
a shutdown was initiated.
@tobim tobim requested a review from a team March 25, 2021 10:05
@tobim tobim added the bug Incorrect behavior label Mar 25, 2021
@tobim tobim enabled auto-merge March 25, 2021 11:07
@tobim tobim disabled auto-merge March 25, 2021 11:07
dominiklohmann
dominiklohmann approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this to work locally with a setup that I also confirmed to hang without this patch. Please move the new log message to DBEUG. The code looks alright to me—thanks for the s/_/- in the actor name as well.

@tobim
Copy link
Member Author

tobim commented Mar 25, 2021

thanks for the s/_/- in the actor name as well.

The process for solving this was:

  1. Adding disk-monitor to the singletons list and pipeline -> didn't work
  2. Adding the log message -> 💡
  3. Changing the actor name

@tobim tobim merged commit 4d8c44c into master Mar 25, 2021
@tobim tobim deleted the story/ch24209/disk-monitor-shutdown branch March 25, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @dominiklohmann